Skip to content

[SPARK-10584][DOC][SQL] Documentation about spark.sql.hive.metastore.version is wrong.#8739

Closed
sarutak wants to merge 3 commits into
apache:masterfrom
sarutak:SPARK-10584
Closed

[SPARK-10584][DOC][SQL] Documentation about spark.sql.hive.metastore.version is wrong.#8739
sarutak wants to merge 3 commits into
apache:masterfrom
sarutak:SPARK-10584

Conversation

@sarutak

@sarutak sarutak commented Sep 14, 2015

Copy link
Copy Markdown
Member

The default value of hive metastore version is 1.2.1 but the documentation says the value of spark.sql.hive.metastore.version is 0.13.1.
Also, we cannot get the default value by sqlContext.getConf("spark.sql.hive.metastore.version").

@srowen

srowen commented Sep 14, 2015

Copy link
Copy Markdown
Member

That looks right just reading the code but I'm not an expert.

@SparkQA

SparkQA commented Sep 14, 2015

Copy link
Copy Markdown

Test build #42406 has finished for PR 8739 at commit 053b17d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai

yhuai commented Sep 14, 2015

Copy link
Copy Markdown
Contributor

LGTM. Merging to master and branch 1.5.

asfgit pushed a commit that referenced this pull request Sep 14, 2015
…e.version is wrong.

The default value of hive metastore version is 1.2.1 but the documentation says the value of `spark.sql.hive.metastore.version` is 0.13.1.
Also, we cannot get the default value by `sqlContext.getConf("spark.sql.hive.metastore.version")`.

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>

Closes #8739 from sarutak/SPARK-10584.

(cherry picked from commit cf2821e)
Signed-off-by: Yin Huai <yhuai@databricks.com>
@asfgit asfgit closed this in cf2821e Sep 14, 2015
@sarutak

sarutak commented Sep 15, 2015

Copy link
Copy Markdown
Member Author

@yhuai I found some more 1.3 or 1.3.1 in the document.
One, The Thrift JDBC/ODBC server implemented here corresponds to the HiveServer2 in Hive 0.13.
One, Spark SQL is designed to be compatible with the Hive Metastore, SerDes and UDFs. Currently Spark SQL is based on Hive 0.12.0 and 0.13.1.

Are these collect?

@yhuai

yhuai commented Sep 15, 2015

Copy link
Copy Markdown
Contributor

@sarutak Looks like they need to be updated. Can you send another PR? Thanks!

@sarutak

sarutak commented Sep 16, 2015

Copy link
Copy Markdown
Member Author

O.K. I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants